Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test coverage reports with nyc #27

Merged
merged 6 commits into from
Dec 4, 2024
Merged

fix: test coverage reports with nyc #27

merged 6 commits into from
Dec 4, 2024

Conversation

gpmayorga
Copy link
Collaborator

Description

This pull request fixes the coverage reports as they were only picking up to files under /src/
https://app.codecov.io/gh/centrifuge/sdk?search=&displayType=list

#

@gpmayorga gpmayorga added the no-release Label to indicate not to release this PR label Dec 3, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.46%. Comparing base (6c8d1ef) to head (5fc178a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main      #27       +/-   ##
==========================================
+ Coverage   0.00%   86.46%   +86.46%     
==========================================
  Files          2       24       +22     
  Lines          3     3029     +3026     
  Branches       0      253      +253     
==========================================
+ Hits           0     2619     +2619     
- Misses         3      404      +401     
- Partials       0        6        +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gpmayorga gpmayorga merged commit dbe1cc7 into main Dec 4, 2024
3 checks passed
@gpmayorga gpmayorga deleted the fix-test-coverage branch December 4, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Label to indicate not to release this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants