Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split LpMessage traits in subtraits #1977

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Conversation

lemunozm
Copy link
Contributor

@lemunozm lemunozm commented Aug 18, 2024

Description

Split the different behaviors of LpMessage in subtraits that can be handled separately. See this thread

NOTE: It is not mandatory to be merged before the audit. Also does not requite to update any doc.

@lemunozm lemunozm added the I6-refactoring Code needs refactoring. label Aug 18, 2024
@lemunozm lemunozm requested a review from cdamian August 18, 2024 18:29
@lemunozm lemunozm self-assigned this Aug 18, 2024
@lemunozm lemunozm requested a review from wischli August 18, 2024 19:00
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 🤩

@lemunozm lemunozm enabled auto-merge (squash) August 18, 2024 19:10
@lemunozm lemunozm merged commit 7126ef9 into main Aug 18, 2024
11 of 13 checks passed
@lemunozm lemunozm deleted the ref/lp-message-traits-split branch August 18, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I6-refactoring Code needs refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants