fix: gateway migration et al. #1950
Conversation
wischli
added
I3-annoyance
|
Thank you very much @wischli!!! <3 |
| fn on_runtime_upgrade() -> Weight { | ||
| let mut weight = Weight::zero(); | ||
|
|
||
| match clear_prefix(&get_storage_prefix(), Some(REMOVAL_LIMIT)) { |
There was a problem hiding this comment.
I know this is not the way we should do it and instead I should set up the old storage entry with the deprecated tranche currency type but I hope we can make an exception here because of the limited time until the audit. This prefix does not exist anymore in v2.
On Centrifuge Chain, there are 3 FI entries with a total of 0.000006 USDC. I discussed with Jay that we can discard it. Swapping with Orderbook is not possible because the amounts are too low.
There was a problem hiding this comment.
Agree! Thanks for the explanation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/lp-v2-gateway-queue-migration #1950 +/- ##
=====================================================================
Coverage ? 47.90%
=====================================================================
Files ? 184
Lines ? 12920
Branches ? 0
=====================================================================
Hits ? 6189
Misses ? 6731
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
It seems like our try-runtime CI job is broken 🤔 |
9dc9c03 should fix it. |
* migration: Add LP Gateway migration for outbound messages * fix: gateway migration et al. (#1950) * chore: remove deprecated DMP Queue * chore: remove deprecated custom migrations * fix: gateway migration * fix: rm FI v1 storage entries * ci: fix try-runtime cli by adding install --------- Co-authored-by: William Freudenberger <[email protected]>
Description
ForeignInvestmentInfov1 storage entries (see Slack for context)Checklist: