Loans: cashflows simple version #1867
Conversation
* correct principal/interest for both kind of loans * support for external prices * add external test
lemunozm
added
P7-asap
| @@ -364,6 +384,8 @@ impl<T: Config> ActiveLoan<T> { | |||
| } | |||
| } | |||
|
|
|||
| self.repayments_on_schedule_until = T::Time::now(); | |||
There was a problem hiding this comment.
@mustermeiszer @hieronx should I add this line into the repay() method as well?
There was a problem hiding this comment.
It is atm not having any effect, right? Then I would do so.
There was a problem hiding this comment.
It has, because the cashflow() is computed to start from that point: https://github.com/centrifuge/centrifuge-chain/pull/1867/files#diff-637356fbd7809c17265d6b8ab519abc2b0ffa4df672cfb33a321795190f441baR254
Then I'll add it
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1867 +/- ##
==========================================
+ Coverage 46.64% 46.67% +0.02%
==========================================
Files 167 169 +2
Lines 13145 13203 +58
==========================================
+ Hits 6132 6162 +30
- Misses 7013 7041 +28 ☔ View full report in Codecov by Sentry. |
|
Could you add a very short description of the breaking API change to the PR description please @lemunozm? Will use this for the release. |
|
Sorry! it was in the old closed PR:
|
Description
A simplified version of #1797 when only one payment at maturity is expected. No monthly cashflows