Feat: Liquidity pools inter domain tranche token transfer #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we start adding test to the pallet itself now? ^^ Integration test will be hard until the LP integration test is not done. |
lemunozm
reviewed
Jun 5, 2024
| @@ -1,99 +0,0 @@ | |||
| // Copyright 2023 Centrifuge Foundation (centrifuge.io). | |||
There was a problem hiding this comment.
Why are these pallets removed?
There was a problem hiding this comment.
unused config, right?
There was a problem hiding this comment.
Ah, that's right! I forgot to remove those files after migrating them 🤦🏻♂️. Thanks
wischli
reviewed
Jun 5, 2024
| tranche_id, | ||
| receiver, | ||
| amount, | ||
| )?; |
There was a problem hiding this comment.
Love the simplicity of this feature!
wischli
approved these changes
Jun 6, 2024
lemunozm
approved these changes
Jun 6, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR allows to send tranche tokens from
Domain AtoDomain Bby relaying the message overCentrifuge. The Solidity side of the LP logic already is capable of doing so, this enables this feature on the chain itself.NOTE:
Pushing this change before the RU as the DYF pool will most likely need that feature.
Changes and Descriptions
DomainAccountToDomainAddressconverter to ease conversion from message to typeDomainAccounttoT::DomainAddressToAccountId::convert(receiver)→ for local receiver this will just be the normal account they choose to send to
→ for remote receiver this will be a derived account that temporarily holds the tokens
Checklist: