Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow root to propose and remove fees #1855

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Jun 3, 2024

Description

Fixes #1847

Changes and Descriptions

  • Feat: Allow root origin for proposing fees
  • Fix: Allow root origin for removing fees if fee editor is configured as Root

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@wischli wischli added I2-bug The code fails to follow expected behaviour. D0-ready Pull request can be merged without special precaution and notification. labels Jun 3, 2024
@wischli wischli added this to the Centrifuge 1029 milestone Jun 3, 2024
@wischli wischli self-assigned this Jun 3, 2024
@wischli wischli requested review from cdamian and lemunozm June 3, 2024 13:36
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and clean!

@wischli wischli enabled auto-merge (squash) June 3, 2024 14:08
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 46.50%. Comparing base (c6dea28) to head (30590d1).

Files Patch % Lines
pallets/pool-fees/src/lib.rs 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1855      +/-   ##
==========================================
- Coverage   46.54%   46.50%   -0.04%     
==========================================
  Files         167      167              
  Lines       13101    13105       +4     
==========================================
- Hits         6098     6095       -3     
- Misses       7003     7010       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wischli wischli merged commit 4b9e47e into main Jun 3, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0-ready Pull request can be merged without special precaution and notification. I2-bug The code fails to follow expected behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Permit root to execute pool fees calls
2 participants