Borrow proxy with PodOperation behavior #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
Q1-easy
lemunozm
changed the title
wischli
previously approved these changes
Jun 3, 2024
runtime/centrifuge/src/lib.rs
Outdated
| @@ -693,7 +693,8 @@ impl InstanceFilter<RuntimeCall> for ProxyType { | |||
| // Borrowers should be able to swap back and forth between local currencies and their variants | |||
| RuntimeCall::TokenMux(pallet_token_mux::Call::burn {..}) | | |||
| RuntimeCall::TokenMux(pallet_token_mux::Call::deposit {..}) | | |||
| RuntimeCall::TokenMux(pallet_token_mux::Call::match_swap {..}) | |||
| RuntimeCall::TokenMux(pallet_token_mux::Call::match_swap {..}) | | |||
| ProxyType::PodOperation.filter(c) | |||
There was a problem hiding this comment.
I love the simplicity of this solution!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1854 +/- ##
==========================================
- Coverage 46.57% 46.50% -0.08%
==========================================
Files 167 167
Lines 13098 13101 +3
==========================================
- Hits 6100 6092 -8
- Misses 6998 7009 +11 ☔ View full report in Codecov by Sentry. |
wischli
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want the
ProxyType::Borrowto also behaves as theProxyType::PodOperation. Thread: https://kflabs.slack.com/archives/C04GJQAM9P0/p1717154483749839