-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Open Gov for Development and Altair Runtimes #1828
Changes from 2 commits
bb5c278
74acbd3
bfb36ae
f530ee5
5a3e4ba
7ef53e8
4d78c10
dd7884c
d369536
bc41393
8d4a231
dc39024
c7b1f18
9a4950a
bc2ae52
a98666b
c7be7f9
27ea745
7175fe9
4beb919
aef53a3
9c50dd4
dd97b2a
cb9bb3b
05c50aa
230651d
6b11298
c4c78a2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,45 +10,6 @@ | |
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU General Public License for more details. | ||
|
||
use cfg_primitives::AccountId; | ||
use frame_support::parameter_types; | ||
use sp_std::{vec, vec::Vec}; | ||
|
||
use crate::{OraclePriceCollection, OraclePriceFeed}; | ||
|
||
// Number of identities on Centrifuge Chain on 29.05.2024 was 34 | ||
const IDENTITY_MIGRATION_KEY_LIMIT: u64 = 1000; | ||
|
||
parameter_types! { | ||
// Address used by Anemoy to withdraw in AssetHub | ||
// 4dTeMxuPJCK7zQGhFcgCivSJqBs9Wo2SuMSQeYCCuVJ9xrE2 --> 5CSfibAR9HHEwKpXbdsDHguAmLgKS6yKat2joTLA75DZ152L | ||
pub AccountMap: Vec<(AccountId, AccountId)> = vec![ | ||
( | ||
AccountId::new(hex_literal::hex!("5dbb2cec05b6bda775f7945827b887b0e7b5245eae8b4ef266c60820c9377185")), | ||
AccountId::new(hex_literal::hex!("10c03288a534d77418e3c19e745dfbc952423e179e1e3baa89e287092fc7802f")) | ||
) | ||
]; | ||
} | ||
|
||
/// The migration set for Centrifuge @ Polkadot. | ||
/// It includes all the migrations that have to be applied on that chain. | ||
pub type UpgradeCentrifuge1103 = ( | ||
runtime_common::migrations::increase_storage_version::Migration<OraclePriceFeed, 0, 1>, | ||
runtime_common::migrations::increase_storage_version::Migration<OraclePriceCollection, 0, 1>, | ||
pallet_collator_selection::migration::v1::MigrateToV1<crate::Runtime>, | ||
pallet_collator_selection::migration::v2::MigrationToV2<crate::Runtime>, | ||
runtime_common::migrations::loans::AddWithLinearPricing<crate::Runtime>, | ||
runtime_common::migrations::hold_reason::MigrateTransferAllowListHolds< | ||
crate::Runtime, | ||
crate::RuntimeHoldReason, | ||
>, | ||
// Migrations below this comment originate from Polkadot SDK | ||
pallet_xcm::migration::MigrateToLatestXcmVersion<crate::Runtime>, | ||
cumulus_pallet_xcmp_queue::migration::v4::MigrationToV4<crate::Runtime>, | ||
pallet_identity::migration::versioned::V0ToV1<crate::Runtime, IDENTITY_MIGRATION_KEY_LIMIT>, | ||
pallet_uniques::migration::MigrateV0ToV1<crate::Runtime, ()>, | ||
runtime_common::migrations::restricted_location::MigrateRestrictedTransferLocation< | ||
crate::Runtime, | ||
AccountMap, | ||
>, | ||
); | ||
pub type UpgradeCentrifuge1200 = (); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, we need to be sure we use the 1103 as RU to apply the previous migrations 👍🏻 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes but since 1103 is already proposed to Council, that shouldnt be an issue. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,7 @@ parameter_types! { | |
|
||
/// The migration set for Development & Demo. | ||
/// It includes all the migrations that have to be applied on that chain. | ||
pub type UpgradeDevelopment1100 = ( | ||
pub type UpgradeDevelopment1200 = ( | ||
// Initialize OpenGov Technical Committee with Alice | ||
runtime_common::migrations::technical_comittee::InitMigration<crate::Runtime, InitialTcMembers>, | ||
runtime_common::migrations::increase_storage_version::Migration<crate::Referenda, 0, 1>, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just curious, a pallet just added to the runtime, does not contain the latest version? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Apparently! I have to admit that I did not dig deeper into this but |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: Bumping to 1200 here and removing outdated migrations for all runtimes so I can use this as RC for Altair.