fix: undecodable ForeignInvestmentInfo on Demo

[wischli]

Description

• Bumps Demo spec version to 1047
• Adds two new utility functions for migrations which enable counting and removing undecodable storage entries
• Removes one undecodable ForeignInvestmentInfo entry for dev runtime on Demo

Dev Logs

[2024-04-19T10:42:41Z INFO  development_runtime::migrations::cleanup_foreign_investments] CleanupForeignInvestments Initiating removal of undecodable keys
[2024-04-19T10:42:41Z INFO  development_runtime::migrations::cleanup_foreign_investments] CleanupForeignInvestments Removed 0 undecodable keys

Demo Logs

[2024-04-19T10:40:42Z INFO  development_runtime::migrations::cleanup_foreign_investments] CleanupForeignInvestments Failed to decode 1 keys, cleanup necessary
[2024-04-19T10:40:42Z INFO  development_runtime::migrations::cleanup_foreign_investments] CleanupForeignInvestments pre_upgrade done!
[2024-04-19T10:40:42Z INFO  development_runtime::migrations::cleanup_foreign_investments] CleanupForeignInvestments Initiating removal of undecodable keys
[2024-04-19T10:40:42Z ERROR runtime::storage] Corrupted state at `[70, 74, 237, 145, 57, 25, 186, 185, 47, 121, 243, 199, 183, 157, 40, 247, 239, 186, 193, 94, 147, 243, 120, 17, 137, 94, 38, 6, 5, 205, 196, 135, 164, 245, 206, 214, 102, 137, 87, 187, 42, 154, 149, 78, 126, 80, 245, 181, 4, 0, 0, 0, 0, 0, 0, 0]: Error`
[2024-04-19T10:40:42Z INFO  development_runtime::migrations::cleanup_foreign_investments] CleanupForeignInvestments Removed 1 undecodable keys
[2024-04-19T10:40:42Z INFO  development_runtime::migrations::cleanup_foreign_investments] CleanupForeignInvestments post_upgrade done with 4 remaining storage keys!

Checklist:

• I have added Rust doc comments to structs, enums, traits and functions
• I have made corresponding changes to the documentation
• I have performed a self-review of my code
• I have added tests that prove my fix is effective or that my feature works

[lemunozm]

Thanks for this! Really cool migration!

One question. Do we know why this storage was undecodable?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 48.56%. Comparing base (97cb823) to head (4dd6bd0).

Files	Patch %	Lines
runtime/common/src/migrations/mod.rs	0.00%	26 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1819      +/-   ##
==========================================
- Coverage   48.66%   48.56%   -0.10%     
==========================================
  Files         167      168       +1     
  Lines       13318    13344      +26     
==========================================
  Hits         6481     6481              
- Misses       6837     6863      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lemunozm]

Thanks again for this! 🙌🏻