Feat: Enhance Error Resolution EVM

[mustermeiszer]

Description

Currently, the EVM does never error out if the execution of the EVM failed for some reason. In most case it will be an active Revert faced from some checks on the EVM side.

But Substrate does not see that. It will only see an okay, resulting in wrong assumptions.

NOTE:
This change does mean that the EVM side DOES change but the Substrate side is still transactional. In most cases the EVM side will only contain fee-payment and new Pending appends.

Changes and Descriptions

• Check last Pending to fetch status code of transaction

Checklist:

• I have added Rust doc comments to structs, enums, traits and functions
• I have made corresponding changes to the documentation
• I have performed a self-review of my code
• I have added tests that prove my fix is effective or that my feature works

[cdamian]

Nice to finally have a way of seeing EVM execution errors.

[wischli]

LGTM! Minor nit on the possibility of deconstructing the Pending tuple. Certainly not a blocker. Thanks for dealing with this so quickly 🚀

[wischli]

Thanks for satisfying the pedantic of the team 🥇

[mustermeiszer]

@cdamian any idea how you would fix the test without not calling send on the routers? Do you think we need a dummy contract or can we get around that?

[cdamian]

@cdamian any idea how you would fix the test without not calling send on the routers? Do you think we need a dummy contract or can we get around that?

@mustermeiszer we might need a dummy contract, but lemme grab this branch and take a closer look.

[mustermeiszer]

Maybe we can mock the ethereum calling logic

[cdamian]

#1760 has a fix for the current test failures.

[lemunozm]

Cool change!