Minor Docker enhancements #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description This PR: - Sets some additional RFC standard LABELS to our Docker container - Upload the container to both GitHub and DockerHub registries (PRs do not upload to DH) - Minor Dockerfile efficiencies. It's a follow up from #1656
gpmayorga
commented
Dec 26, 2023
| with: | ||
| username: ${{ secrets.DOCKER_HUB_USERNAME }} | ||
| password: ${{ secrets.DOCKER_HUB_TOKEN }} | ||
|
|
||
| - run: echo "NOW=$(date -u +%y-%m-%d)" >> $GITHUB_ENV |
There was a problem hiding this comment.
Updated date according to standard RFC 3339 with full year instead of 2 digits
gpmayorga
commented
Dec 26, 2023
| images: centrifugeio/centrifuge-chain | ||
| images: | | ||
| ghcr.io/centrifuge/centrifuge-chain | ||
| ${{ github.event_name != 'pull_request' && 'centrifugeio/centrifuge-chain' || ''}} |
There was a problem hiding this comment.
Only push to DockerHub if it's not a PR
gpmayorga
commented
Dec 26, 2023
|
|
||
| LABEL io.centrifuge.image.authors="[email protected]" \ |
There was a problem hiding this comment.
LABELS are set using the GHA pipleline on the metadata step.
Ideally we don't publish images from our laptops and thus no need to have this here
gpmayorga
added
D0-ready
lemunozm
reviewed
Dec 27, 2023
wischli
reviewed
Jan 2, 2024
wischli
approved these changes
Jan 10, 2024
wischli
approved these changes
Jan 16, 2024
wischli
pushed a commit
that referenced
this pull request
Jan 29, 2024
* Add a readiness check to the Docker container * missing path change for centrifuge binary * push docker to GH registry on PRs to test image * more standard paths for the binaries * log into ghcr * Add standardized OCI labels * push to both registries * fix registry permissions * comply with RFC3339 standard date format * Minor Docker enhancements # Description This PR: - Sets some additional RFC standard LABELS to our Docker container - Upload the container to both GitHub and DockerHub registries (PRs do not upload to DH) - Minor Dockerfile efficiencies. It's a follow up from #1656 * cleanup from old PR * Update build-docker.yml with kf info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
It's a follow up from #1656