Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker workflow triggers #1646

Merged
merged 9 commits into from
Dec 12, 2023
Merged

Fix Docker workflow triggers #1646

merged 9 commits into from
Dec 12, 2023

Conversation

gpmayorga
Copy link
Contributor

@gpmayorga gpmayorga commented Dec 11, 2023

This PR:

  • Adds an on-demand trigger in case a manual docker tag is needed
  • Adjusts when a release triggers a docker build and push
  • Auto-comments on the release notes adding the docker tags

@gpmayorga
Copy link
Contributor Author

Screenshot 2023-12-11 at 13 51 10

This workflow should be working now.
It will never trigger for DRAFT releases but every other action in publishing a pre-release or a release, or updating it will trigger a Docker build.

@gpmayorga gpmayorga added D0-ready Pull request can be merged without special precaution and notification. Q1-easy Can be done by primarily duplicating and adapting code. labels Dec 11, 2023
@gpmayorga
Copy link
Contributor Author

gpmayorga commented Dec 11, 2023

Screenshot 2023-12-11 at 13 54 40

Example of release tags

@gpmayorga gpmayorga enabled auto-merge (squash) December 11, 2023 14:04
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@gpmayorga gpmayorga merged commit b6c3736 into main Dec 12, 2023
11 checks passed
@lemunozm lemunozm mentioned this pull request Dec 12, 2023
@lemunozm lemunozm deleted the fix-docker-release branch December 12, 2023 11:34
lemunozm added a commit that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0-ready Pull request can be merged without special precaution and notification. Q1-easy Can be done by primarily duplicating and adapting code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants