integration-tests: Use the generic framework for development LP tests #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdamian
force-pushed
the
development-lp-test-refactor
branch
from
5f87e3c to
da1057f
Compare
lemunozm
reviewed
Dec 11, 2023
cdamian
force-pushed
the
development-lp-test-refactor
branch
from
ce47504 to
b86f077
Compare
cdamian
force-pushed
the
development-lp-test-refactor
branch
2 times, most recently
from
658ad6f to
46ad25c
Compare
lemunozm
reviewed
Dec 13, 2023
lemunozm
approved these changes
Dec 13, 2023
| crate::test_for_runtimes!([development], allow_pool_should_fail); | ||
| crate::test_for_runtimes!([development], schedule_upgrade); | ||
| crate::test_for_runtimes!([development], cancel_upgrade); | ||
| crate::test_for_runtimes!([development], update_tranche_token_metadata); |
There was a problem hiding this comment.
Out of curiosity, what's the current problem with the rest of the runtimes?
There was a problem hiding this comment.
I think it's mostly related to the native currency that we use there, and probably some other things that @NunoAlexandre might know better. However, I also think that later on we can probably improve these tests a bit more and try to run them for all runtimes, I'm sure there's a way to achieve that.
cdamian
force-pushed
the
development-lp-test-refactor
branch
from
94aa815 to
3ce7027
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for the
.43update work where only some LP integration tests were added to the generic framework.Checklist: