Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker-compose #1626

Merged
merged 6 commits into from
Dec 1, 2023
Merged

fix: docker-compose #1626

merged 6 commits into from
Dec 1, 2023

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Nov 24, 2023

Description

  • Fixes docker-compose files and usage after moving files and updating Dockerfile in CI release bug fixes  #1611
  • Runs docker-compose containers as root user

How to test locally

PARA_DOCKER_IMAGE_TAG=latestmain-8b9c8f0-23-11-23 PARA_DOCKER_PROFILE=default DOCKER_ONBOARD=true PARA_CHAIN_SPEC=development ./scripts/onboard.sh

onboard.shj

cc_docker_image_tag="${PARA_DOCKER_IMAGE_TAG:-test-main-latest}"
parachain_spec="${PARA_CHAIN_SPEC:-centrifuge-local}"
parachain_method="${PARA_METHOD:-docker}"

export PARA_DOCKER_IMAGE_TAG=$cc_docker_image_tag
export CC_DOCKER_TAG=$cc_docker_image_tag
export PARA_CHAIN_SPEC=$parachain_spec
if [[ $parachain_method == "docker" ]];
then
  export DOCKER_ONBOARD=true
fi

./scripts/init.sh stop-relay-chain
./scripts/init.sh start-relay-chain
if [[ $parachain_method == "docker" ]];
then
  ./scripts/init.sh start-parachain-docker
else
  sleep 10
  ./scripts/init.sh start-parachain
fi
./scripts/init.sh onboard-parachain

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@wischli wischli self-assigned this Nov 24, 2023
@wischli wischli added I2-bug The code fails to follow expected behaviour. D0-ready Pull request can be merged without special precaution and notification. labels Nov 24, 2023
@wischli wischli requested a review from gpmayorga November 24, 2023 14:30
@wischli wischli enabled auto-merge (squash) December 1, 2023 09:32
@wischli wischli merged commit 2ba3d5a into main Dec 1, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0-ready Pull request can be merged without special precaution and notification. I2-bug The code fails to follow expected behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants