CI Testing in debug #1606
CI Testing in debug #1606
Conversation
lemunozm
requested review from
mustermeiszer and
NunoAlexandre
as code owners
|
Can you temporarily adjust the trigger of sanity checks to run for this PR @lemunozm? I would like to compare the execution times. |
lemunozm
force-pushed
the
ci-rewrite-n-cache-debug
branch
from
dd8a5a9 to
5ad1711
Compare
|
It makes total sense! Thanks for the suggestion @wischli |
|
Integration tests fails. I think it's because the amount of logging increases a lot over time. I would set Anyway, I am not sure if we want to have logging by default in integration tests. I would only add them during debugging to analyze a failing test case. cc @mustermeiszer? |
| # push: | ||
| # branches: [main, 'release-v**'] | ||
| push: | ||
| branches: ['ci-rewrite-n-cache'] |
There was a problem hiding this comment.
This should be changed back, right?
There was a problem hiding this comment.
Yes, it there was there just to trigger the CI in this PR
|
Yes, but then we need to compile integration tests in release and workspace tests in debug. I think then it makes no sense running anything in debug 😞 |
|
At least we can not until solving this: https://kflabs.slack.com/archives/C04GJQAM9P0/p1700154518905029 |
Description
CI workflows in debug instead of release.
Note: In the original PR modifying this, the workflow of checking benchmarks was also computed in debug to reuse artifacts (see here). Maybe it's still required here, but it's still not added. Let's see how it behaves.