Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration test: Generic runtime and environment #1583
Integration test: Generic runtime and environment #1583
Changes from 12 commits
45168fa
200d1b4
25d054e
d05c5f5
18aeee6
320945a
7eb6778
99e6892
dbf5ce9
5a44c3b
b4f4cb1
649381b
0a7fa0b
0d514bf
b65d350
b3e52fd
e8fedd5
8ef7fe8
ef9955d
d562ace
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not exactly the fees the last executed extrinsic has consumed. Not sure why or what I'm missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have expected your solution to be correct. Have you compared the current result against the fee returned by
transaction_payment::Event::<T>:TransactionFeePaid { actual_fee, tip }
which should be the event before the last one?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're different, not sure why, but the way of calculating them comes from different paths. The difference is really subtle anyway:
TransactionFeePaid
:ExtrinsicSuccess
:Still investigating, thanks for addressing me to the
TransactionFeePaid
event!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the difference. But as far as I am concerned, using the value from
TransactionFeePaid
works so... I'll give this as solved.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
TransactionFeePaid
includes another signature check which is not included inExtrinsicSuccess
. Just a guess, haven't looked into the code further.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe there's some extra fees for dispatching the transaction? That happens with xcm-related transactions, maybe there's a similar mechanism here involved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there must be some extra fees that do not depend on the weight of the call, so when I do
WeightToFee::weight_to_fee(&dispatch_info.weight)
I'm leaving some fees behind.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still want to do this in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this will be a future PR not to block this. That file is just a placeholder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should create an issue for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1586