Loans: Remove portfolio entry when removing a loan + portfolio UT #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
Q1-easy
lemunozm
force-pushed
the
loans/remove_item_portfolio
branch
from
91cc86b to
9d29e8d
Compare
lemunozm
force-pushed
the
loans/remove_item_portfolio
branch
from
9d29e8d to
1ebaf43
Compare
lemunozm
force-pushed
the
loans/remove_item_portfolio
branch
from
1ebaf43 to
6ba6d57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optional addition: I think it could be beneficial to leave the portfolio values representing the exact loans found in
ActiveLoans. Anyways, the storage is reset for each NAV computation, but having during some time different elements in the portfolio and active loans could lead to errors.PROS: Data more structured.
CONS: 1 read/write DB for
close_loan()action.Changes and Descriptions
portfolio.remove_elem()