feat: orderbook bench helper #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wischli
added
D0-ready
lemunozm
reviewed
Sep 19, 2023
mustermeiszer
previously approved these changes
Sep 21, 2023
lemunozm
reviewed
Sep 21, 2023
|
I would need this PR for: #1563, is this ready to be merged? |
Let me resolve the issues after rebasing and then let's merge this! |
lemunozm
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an benchmark helper to the
pallet-order-bookwhich exposes the necessary setup to register a trading pair for arbitrary currencies.It is inspired by the the existing
PoolBenchmarkHelperwhich was moved to a newbenchmarkingmodule ofcfg_traits.Required for benchmarking LPs, especially foreign investments