Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rate type used in RuntimeAPIs for pools #1543

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

lemunozm
Copy link
Contributor

Description

After #1520 we missed updating the type for runtime APIs. This PR fixes it.

It's not a critical bug because the logic/state/extrinsic are not affected by this. Just the result obtained in the API has more "zeros" than expected.

@lemunozm lemunozm added I2-bug The code fails to follow expected behaviour. Q0-trivial An issure which is similar to patching code. P7-asap Issue should be addressed in the next days. labels Sep 12, 2023
@lemunozm lemunozm self-assigned this Sep 12, 2023
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for handling this so quickly

@lemunozm lemunozm enabled auto-merge (squash) September 12, 2023 07:49
@lemunozm lemunozm merged commit f5a2fb9 into main Sep 12, 2023
10 checks passed
@lemunozm lemunozm deleted the fix/pool-runtime-apì-rates branch September 12, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The code fails to follow expected behaviour. P7-asap Issue should be addressed in the next days. Q0-trivial An issure which is similar to patching code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants