Feat: upgrade1020 misc 2 #1532

mustermeiszer · 2023-09-05T14:39:53Z

Description

Miscellaneous changes for the upgrade. Details see changes

Changes and Descriptions

new EnsureAccoutOrRootOr struct - allows to define an admin account for certain calls
- we need that to block the gatway logic faster than council could do (temporary only until we reach stability on the Centrifuge and Soidity side)
Bumb Development version to 10.21
Adapt weights of pallets

Checklist:

I have added Rust doc comments to structs, enums, traits and functions
I have made corresponding changes to the documentation
I have performed a self-review of my code
I have added tests that prove my fix is effective or that my feature works

runtime/common/src/lib.rs

…20-misc-2

mustermeiszer · 2023-09-05T20:54:30Z

This builds with --release and with --release --features runtime-benchmarks. I will trigger the benchmarks from this branch here as it contains all the latest changes and we must not wait for benchmarks then tomorrow.

mustermeiszer · 2023-09-05T20:54:42Z

/benchmark centrifuge

mustermeiszer · 2023-09-05T20:54:54Z

/benchmark altair

github-actions · 2023-09-05T20:54:59Z

✅ Uploaded benchmarks for: centrifuge ✅
Find the artifact here: https://github.com/centrifuge/centrifuge-chain/actions/runs/6089663515

mustermeiszer · 2023-09-05T20:55:01Z

/benchmark development

github-actions · 2023-09-05T20:55:54Z

✅ Uploaded benchmarks for: altair ✅
Find the artifact here: https://github.com/centrifuge/centrifuge-chain/actions/runs/6089664744

wischli

LGTM! 🚀 Of course, tests need to be fixed.

wischli · 2023-09-06T05:55:25Z

runtime/common/src/lib.rs

+	pub type EnsureAccountOrRootOr<Account, O> = EitherOfDiverse<
+		EitherOfDiverse<EnsureSignedBy<AdminOnly<Account>, AccountId>, EnsureRoot<AccountId>>,
+		O,
+	>;


Nit: Couldn't we simplify this?

Suggested change

pub type EnsureAccountOrRootOr<Account, O> = EitherOfDiverse<

EitherOfDiverse<EnsureSignedBy<AdminOnly<Account>, AccountId>, EnsureRoot<AccountId>>,

O,

>;

pub type EnsureAccountOrRootOr<Account, O> = EitherOfDiverse<

EnsureAccountOrRoot<Account>,

O,

>;

wischli · 2023-09-06T06:25:42Z

pallets/liquidity-pools-gateway/src/weights.rs

+		Weight::from_parts(78_019_565, 19974)
+			.saturating_add(Weight::from_ref_time(38_884_782).saturating_mul(N))
+			.saturating_add(RocksDbWeight::get().reads(8))
+			.saturating_add(RocksDbWeight::get().reads((7_u64).saturating_mul(N)))
+			.saturating_add(RocksDbWeight::get().writes(8))
+			.saturating_add(RocksDbWeight::get().writes((6_u64).saturating_mul(N)))
+			.saturating_add(Weight::from_proof_size(17774).saturating_mul(N))


Note: I made sure this default weight and PoV size for liquidity pool extrinsics is still executable. It is.

I do believe though we should increase it when we introduce foreign investments or did you factor that in already?

I did too ^^

No, I think we should increase it.

mustermeiszer · 2023-09-06T07:40:46Z

Integration tests and test go through locally I will merge that now. We can run final CI on feature branch then.

* wip xcm v3 asset-registry migrations * fix: xcm v3 altair, centrifuge * feat: add defensive SafeCallFilter for transact * clean up asset addition for catalyst & centrifuge * add Altair + Algol migration * Add Liquidity Pools related pallets to centrifuge runtime (#1523) * centrifuge: Add liquidity pools pallets to runtime * centrifuge: Add LP OutboundQueue wrapper to runtime * taplo: Obey * runtime: Move OutboundQueue import * centrifuge: Allow both root and half of council as admin origins for LP pallets * centrifuge: Add Axelar Gateway precompile * centrifuge: Use correct HRMP encoder, update HRMP fee to 1 DOT, use XCM V3 imports * centrifuge: Update error message for InboundQueue * clippy: Fix warnings * centrifuge: Rename outbound queue, fix migration import for orml asset registry * Upgrade1020 LP follow-ups (#1525) * centrifuge: Enable LP gateway XCM origin converter * centrifuge: Update LP pallet config to use Quantity for BalanceRatio * runtime: Update XCM origin converter, use Quantity in LP message, add OriginRecovery to LP gateway * feat: safe XCM version migration + extend SafeCallFilter (#1526) * fix: allow gateway process msg for xcm * feat: add safe xcm version migration * fix: Allow process_msg for xcm transact * refactor: remove spec_version check * refactor: stricter SafeCallFilter * Upgrade1020 LP follow-ups (#1525) * centrifuge: Enable LP gateway XCM origin converter * centrifuge: Update LP pallet config to use Quantity for BalanceRatio * runtime: Update XCM origin converter, use Quantity in LP message, add OriginRecovery to LP gateway * fix: rm OrderBook safe call cause missing * fix: OrderBook missing in both runtimes * fix: clippy --------- Co-authored-by: Cosmin Damian <[email protected]> * Feat/upgrade1020 misc 1 (#1529) * fix: asset metadata xcm v3 migration cleanup other migrations (#1528) * fix: centrifuge asset migration * Apply suggestions from code review Co-authored-by: Frederik Gartenmeister <[email protected]> * chore: append cfg assets to catalyst * fix: asset registry migration improvements * feat: apply asset metadata migration to altair runtime * fix: cleanup altair/algol migrations * fix: less aggressive nuke pre-upgrade * fix: finalize migrations, add context * fix: clippy + cleanup imports * fix: native currency altair, algol * fix: Algol native currency name --------- Co-authored-by: Frederik Gartenmeister <[email protected]> * fmt * fixup * Upgrade1020 gateway changes (#1531) * gateway: Use BoundedVec instead of EVMChain enum * gateway: Add Sender type to LP gateway config * gateway: Rename EVM chain size const, emit event when submitting message, adjust gateway sender provider * Feat: upgrade1020 misc 2 (#1532) * feat: account ensuring origin * feat: bumb runtime version develpment * fix: allow council to control gatway on Altair based chains * fix: use EnsureSigned, make use of type and add admin * feat: overestimated weights for lp logic * fix: taplooo * fix: tests and comment * chore: bump weights for 1020 (#1533) * chore: update centrifuge, altair weights * feat: bump and improve dev weights * fix: transfer_allowlist weights * feat: normalize SafeCallFilter across runtimes * fix: native asset key in migration --------- Co-authored-by: William Freudenberger <[email protected]> Co-authored-by: Cosmin Damian <[email protected]> Co-authored-by: Frederik Gartenmeister <[email protected]> Co-authored-by: nuno <[email protected]>

mustermeiszer added 2 commits September 5, 2023 16:26

feat: account ensuring origin

ee6c6d0

feat: bumb runtime version develpment

2431d22

mustermeiszer requested review from mikiquantum, NunoAlexandre, hieronx, wischli, lemunozm and cdamian as code owners September 5, 2023 14:39

mustermeiszer changed the base branch from main to upgrade1020 September 5, 2023 14:40

fix: allow council to control gatway on Altair based chains

8903331

NunoAlexandre reviewed Sep 5, 2023

View reviewed changes

runtime/common/src/lib.rs Outdated Show resolved Hide resolved

mustermeiszer added 4 commits September 5, 2023 20:55

fix: use EnsureSigned, make use of type and add admin

3f4d05a

feat: overestimated weights for lp logic

0fe4cff

Merge remote-tracking branch 'origin/upgrade1020' into feat/upgrade10…

5a62dd3

…20-misc-2

fix: taplooo

c1e5d34

wischli approved these changes Sep 6, 2023

View reviewed changes

fix: tests and comment

fbb35fe

mustermeiszer merged commit 518572f into upgrade1020 Sep 6, 2023
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: upgrade1020 misc 2 #1532

Feat: upgrade1020 misc 2 #1532

mustermeiszer commented Sep 5, 2023

mustermeiszer commented Sep 5, 2023

mustermeiszer commented Sep 5, 2023

mustermeiszer commented Sep 5, 2023

github-actions bot commented Sep 5, 2023 •

edited

Loading

mustermeiszer commented Sep 5, 2023

github-actions bot commented Sep 5, 2023 •

edited

Loading

wischli left a comment •

edited

Loading

wischli Sep 6, 2023

wischli Sep 6, 2023 •

edited

Loading

mustermeiszer Sep 6, 2023

mustermeiszer Sep 6, 2023

mustermeiszer commented Sep 6, 2023

Feat: upgrade1020 misc 2 #1532

Feat: upgrade1020 misc 2 #1532

Conversation

mustermeiszer commented Sep 5, 2023

Description

Changes and Descriptions

Checklist:

mustermeiszer commented Sep 5, 2023

mustermeiszer commented Sep 5, 2023

mustermeiszer commented Sep 5, 2023

github-actions bot commented Sep 5, 2023 • edited Loading

mustermeiszer commented Sep 5, 2023

github-actions bot commented Sep 5, 2023 • edited Loading

wischli left a comment • edited Loading

Choose a reason for hiding this comment

wischli Sep 6, 2023

Choose a reason for hiding this comment

wischli Sep 6, 2023 • edited Loading

Choose a reason for hiding this comment

mustermeiszer Sep 6, 2023

Choose a reason for hiding this comment

mustermeiszer Sep 6, 2023

Choose a reason for hiding this comment

mustermeiszer commented Sep 6, 2023

github-actions bot commented Sep 5, 2023 •

edited

Loading

github-actions bot commented Sep 5, 2023 •

edited

Loading

wischli left a comment •

edited

Loading

wischli Sep 6, 2023 •

edited

Loading