Loans: multiple cashflows PoC #1408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
reviewed
Jun 26, 2023
hieronx
commented
Jun 27, 2023
| @@ -52,6 +52,7 @@ impl<Rate: FixedPointNumber> DiscountedCashFlow<Rate> { | |||
| }) | |||
| } | |||
|
|
|||
| // TODO: this should account for cashflows from interest payments | |||
There was a problem hiding this comment.
We should tackle this in a future PR
pallets/loans/src/types/mod.rs
Outdated
| Balance: tokens::Balance + FixedPointOperand, | ||
| Rate: FixedPointNumber, | ||
| { | ||
| // TODO: once we implement a pay_down_schedule other than `None`, |
There was a problem hiding this comment.
We should tackle this in a future PR
lemunozm
reviewed
Jul 3, 2023
lemunozm
force-pushed
the
multi-cashflows
branch
from
252dc29 to
bb9ae51
Compare
|
I've redo the PR because 99% of the changes were git conflicts with others PRs. I hope I did it well. |
lemunozm
force-pushed
the
multi-cashflows
branch
from
f188035 to
24b7c29
Compare
…into multi-cashflows
|
Re-created branch & PR #1797 Most of the code generated conflicts when rebasing, and I want to maintain this as it is as reference. |
lemunozm
added a commit
that referenced
this pull request
Jun 7, 2024
* updated from #1408 * add testing * organize and polish cashflow module * add Runtime API * update types.md * make it works without chronoutils * minor changes * add borrow check * fix legacy increase_debt test * add loan cashflow tests * compute principal and interest * correct validation * add CashflowPayment type * add variant error * fix interest computation when months are partial * remove Rate usage and use weight * fix start date for cashflows * rename api name * fix benchmarks * taplo fmt * using a lower discount rate to simply benchmarking * rewrite doc line * interest computed at maturity * remove borrow support * fix compilation * None to OnceAtMaturity variant * compilation fixes * Loans: multi cashflows fix external loan (#1864) * correct principal/interest for both kind of loans * support for external prices * add external test * simplify implementation * start from repayments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a basic PoC for multiple cashflows, specifically monthly or semi-annual interest payments, as well as a corresponding write-off trigger.
Checklist: