Avoid erroring out when collection is outdated

centrifuge · Feb 23, 2024 · e52e958 · e52e958
1 parent 39d2e3f
commit e52e958
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/libs/mocks/src/data.rs b/libs/mocks/src/data.rs
@@ -97,6 +97,14 @@ pub mod pallet {
 			}
 		}
 
+		impl<DataId, Data> Default for MockDataCollection<DataId, Data> {
+			fn default() -> Self {
+				Self(Box::new(|_| {
+					Err(DispatchError::Other("MockDataCollection: Data not found"))
+				}))
+			}
+		}
+
 		impl<DataId, Data> DataCollection<DataId> for MockDataCollection<DataId, Data> {
 			type Data = Data;
 

diff --git a/libs/traits/src/data.rs b/libs/traits/src/data.rs
@@ -37,7 +37,7 @@ pub trait DataRegistry<DataId, CollectionId> {
 }
 
 /// Abstration to represent a collection of data in memory
-pub trait DataCollection<DataId> {
+pub trait DataCollection<DataId>: Default {
 	/// Represents a data
 	type Data;
 

diff --git a/pallets/loans/src/lib.rs b/pallets/loans/src/lib.rs
@@ -1046,7 +1046,7 @@ pub mod pallet {
 			pool_id: T::PoolId,
 		) -> Result<(T::Balance, u32), DispatchError> {
 			let rates = T::InterestAccrual::rates();
-			let prices = T::PriceRegistry::collection(&pool_id)?;
+			let prices = T::PriceRegistry::collection(&pool_id).unwrap_or_default();
 			let loans = ActiveLoans::<T>::get(pool_id);
 			let values = loans
 				.iter()