Skip to content

Commit

Permalink
drop more todos
Browse files Browse the repository at this point in the history
  • Loading branch information
NunoAlexandre committed Nov 1, 2023
1 parent 49e880d commit 32f0db7
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
1 change: 0 additions & 1 deletion runtime/altair/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1334,7 +1334,6 @@ impl pallet_membership::Config for Runtime {
}

parameter_types! {
//todo(nuno): check this value
pub const MaxFeedValues: u32 = 10;
}

Expand Down
4 changes: 1 addition & 3 deletions runtime/centrifuge/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,6 @@ impl pallet_balances::Config for Runtime {
/// The minimum amount required to keep an account open.
type ExistentialDeposit = ExistentialDeposit;
type FreezeIdentifier = ();
//todo(nuno)
type HoldIdentifier = ();
type MaxFreezes = ();
type MaxHolds = frame_support::traits::ConstU32<1>;
Expand Down Expand Up @@ -821,7 +820,7 @@ parameter_types! {
pub const DesiredRunnersUp: u32 = 9;
pub const ElectionsPhragmenModuleId: LockIdentifier = *b"phrelect";
// todo(nuno)
pub const MaxVotesPerVoter: u32 = 5;
pub const MaxVotesPerVoter: u32 = 20;
}

// Make sure that there are no more than `MAX_MEMBERS` members elected via
Expand Down Expand Up @@ -1684,7 +1683,6 @@ impl pallet_membership::Config for Runtime {
}

parameter_types! {
//todo(nuno): check this value
pub const MaxFeedValues: u32 = 10;
}

Expand Down
5 changes: 1 addition & 4 deletions runtime/development/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,6 @@ impl pallet_balances::Config for Runtime {
/// The minimum amount required to keep an account open.
type ExistentialDeposit = ExistentialDeposit;
type FreezeIdentifier = ();
//todo(nuno)
type HoldIdentifier = ();
type MaxFreezes = ();
type MaxHolds = frame_support::traits::ConstU32<1>;
Expand Down Expand Up @@ -691,8 +690,7 @@ parameter_types! {
pub const DesiredMembers: u32 = 7;
pub const DesiredRunnersUp: u32 = 3;
pub const ElectionsPhragmenModuleId: LockIdentifier = *b"phrelect";
// todo(nuno)
pub const MaxVotesPerVoter: u32 = 5;
pub const MaxVotesPerVoter: u32 = 20;
}

// Make sure that there are no more than `MAX_MEMBERS` members elected via
Expand Down Expand Up @@ -1318,7 +1316,6 @@ impl pallet_membership::Config for Runtime {
}

parameter_types! {
//todo(nuno): check this value
pub const MaxFeedValues: u32 = 10;
}

Expand Down

0 comments on commit 32f0db7

Please sign in to comment.