Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assets page fixes & wallet button new design #2536

Merged
merged 13 commits into from
Nov 14, 2024
Merged

Assets page fixes & wallet button new design #2536

merged 13 commits into from
Nov 14, 2024

Conversation

kattylucy
Copy link
Collaborator

  • Some post launch UI fixes for assets page
  • New design for wallet button & menu

#2507
#2532

  • Dev

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024 •
edited
Loading

PR deployed in Google Cloud
URL: https://app-pr2536.k-f.dev
Commit #: beba594
To access the functions directly check the corresponding deploy Action

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024 •
edited
Loading

PR deployed in Google Cloud
URL: https://pr2536-app-ff-production.k-f.dev
Commit #: beba594
To access the functions directly check the corresponding deploy Action

@kattylucy kattylucy marked this pull request as ready for review November 8, 2024 12:38
@kattylucy kattylucy force-pushed the 2531-fixes-assets-page branch from 8d9bd61 to d24e174 Compare November 12, 2024 13:35
@kattylucy kattylucy requested a review from onnovisser November 12, 2024 13:48
sophialittlejohn
sophialittlejohn reviewed Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@sophialittlejohn sophialittlejohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is intentional but I think it the wallet button should show the address that's connected and not the wallet?
Screenshot 2024-11-12 at 09 48 47

sophialittlejohn
sophialittlejohn approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@sophialittlejohn sophialittlejohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!!

@kattylucy kattylucy enabled auto-merge (squash) November 14, 2024 16:37
@kattylucy kattylucy merged commit af8f470 into main Nov 14, 2024
11 checks passed
@kattylucy kattylucy deleted the 2531-fixes-assets-page branch November 14, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophialittlejohn sophialittlejohn sophialittlejohn approved these changes

@onnovisser onnovisser Awaiting requested review from onnovisser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kattylucy @sophialittlejohn