-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow for newest version of pip #290
Conversation
WalkthroughThe changes in the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
src/dacy/download.py (2)
77-82
: LGTM! The changes fix pip 24.1 compatibility.
The new implementation correctly uses pip's URL-based installation format required by newer versions. Consider adding error handling for installation failures.
Add error handling to provide better feedback:
def install(package: str, url: str) -> None:
import subprocess
import sys
- subprocess.check_call(
- [sys.executable, "-m", "pip", "install", f"{package} @ {url}", "--no-deps"],
- )
+ try:
+ subprocess.check_call(
+ [sys.executable, "-m", "pip", "install", f"{package} @ {url}", "--no-deps"],
+ stderr=subprocess.PIPE,
+ )
+ except subprocess.CalledProcessError as e:
+ raise RuntimeError(f"Failed to install {package}: {e.stderr.decode()}") from e
118-120
: Consider enhancing package name extraction robustness.
While the implementation works correctly, consider adding validation for the package name extraction to handle edge cases.
- package = model.split("-")[0]
+ package = model.split("-")[0] if "-" in model else model
install(package, models_url[model])
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- src/dacy/download.py (2 hunks)
🔇 Additional comments (1)
src/dacy/download.py (1)
Line range hint 77-120
: Verify model URLs and installation usage.
Let's verify the changes:
- Check if all model URLs in the dictionary are valid
- Look for other places that might need similar updates
✅ Verification successful
Let me check the other files that use pip install to ensure we're not missing any related installation patterns.
Model URLs and installation methods have been verified successfully
The verification shows:
- All model URLs in
models_url
are valid (returning HTTP 302 redirects as expected for Hugging Face URLs) - Other pip install occurrences in the codebase are unrelated to the model installation:
src/dacy/load.py
only contains a warning messagetraining/main/tasks.py
handles dev environment setup- Files in
papers/
directory are documentation/examples for other tools
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for other potential installation methods and verify URLs
# Test 1: Look for other pip install commands that might need updating
echo "Checking for other pip install patterns..."
rg -l "pip.*install" --type py
# Test 2: Verify that all URLs in models_url are valid
echo "Checking model URLs..."
rg -o 'https://huggingface\.co/[^"]*' src/dacy/download.py | while read -r url; do
curl -s -I "$url" | head -n 1 | grep "HTTP/[0-9.]* [23]"
done
Length of output: 1988
Script:
#!/bin/bash
# Check the content of files that use pip install
echo "=== Content of src/dacy/load.py ==="
rg "pip.*install" src/dacy/load.py -A 2 -B 2
echo -e "\n=== Content of training/main/tasks.py ==="
rg "pip.*install" training/main/tasks.py -A 2 -B 2
echo -e "\n=== Content of papers directory ==="
rg "pip.*install" papers/DaCy-A-Unified-Framework-for-Danish-NLP/apply_fns/ -A 2 -B 2
Length of output: 2382
fixes #288
Summary by CodeRabbit
New Features
Bug Fixes