-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Odis Combiner to k8s #47
Conversation
🦋 Changeset detectedLatest commit: 6c46f2f The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments.
Few general questions:
-
Is this PR deprecating
odis-3-combiner-errors
metric in favor ofodis-3-sig-request-errors
? I dont see that we are logging anyodis-3-combiner-errors
-
Will this PR also include the publishing of the common package? If so, the changeset should be added for the common package. Same goes for the signer package.
packages/phone-number-privacy/combiner/src/common/crypto-clients/bls-crypto-client.ts
Show resolved
Hide resolved
packages/phone-number-privacy/combiner/src/common/crypto-clients/domain-crypto-client.ts
Outdated
Show resolved
Hide resolved
packages/phone-number-privacy/combiner/src/pnp/services/account-services.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: soloseng <[email protected]>
Values and docs
Description
Migrate ODIS Combiner from firebase function to k8s. Add Prometheus metrics
Other changes
Tested
CI + e2e and load testing prior to release
Related issues
Backwards compatibility
Backwards compatible with clients thanks to proxying via the old Combiner. Not backwards compatible with old combiner monitoring and alerting / infrastructure
Documentation
NA