feature: add metrics/tracking to remaining agents #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luketchang
changed the title
luketchang
commented
Oct 31, 2021
Comment on lines
76
to
78
| .db | ||
| .retrieve_latest_nonce(domain)? | ||
| .retrieve_keyed_decodable(CURRENT_NONCE, &replica_domain)? | ||
| .map(|n: u32| n + 1) |
There was a problem hiding this comment.
Trying to remove pass through methods in OpticsDB. Also felt that simple agent-unique counter stores didn't belong in OpticsDB so we just use basic db methods here
emberian
reviewed
Nov 1, 2021
| // Relay update and increment counters if tx successful | ||
| if self.replica.update(&signed_update).await.is_ok() { | ||
| self.updates_relayed_count | ||
| .with_label_values(&[self.home.name(), self.replica.name(), AGENT_NAME]) |
There was a problem hiding this comment.
this invocation is constant for every instance of UpdatePoller, which is why in the other PR i made for just the updater stores an already-fully-specified IntCounter inside the UpdatePoller instead of doing it dynamically.
doing so only avoids a single hash of all the labels, though, so 🤷🏼
emberian
reviewed
Nov 1, 2021
| @@ -140,7 +172,8 @@ impl OpticsAgent for Relayer { | |||
| } | |||
| let replica = replica_opt.unwrap(); | |||
|
|
|||
| let update_poller = UpdatePoller::new(home, replica.clone(), duration); | |||
| let update_poller = | |||
| UpdatePoller::new(home, replica.clone(), duration, updates_relayed_count); | |||
There was a problem hiding this comment.
all the information needed to do updates_relayed_count.with_label_values is right here
emberian
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bad dependency but running this in prod is contingent on testing previous updater PR in dev first...
For #917