Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: watcher receives hashmap of connection managers #898

Closed
wants to merge 4 commits into from
Closed

fix: watcher receives hashmap of connection managers #898

wants to merge 4 commits into from

Conversation

luketchang
Copy link
Contributor

config crate doesn't play nice with vectors in json configs so switch to use map of connection managers

Closes #895

@luketchang luketchang requested a review from emberian as a code owner October 14, 2021 19:26
@luketchang luketchang self-assigned this Oct 17, 2021
@luketchang luketchang added agents Relating to rust agents refactor redesign or restructure rust 🦀 Rust dev work required labels Oct 17, 2021
@luketchang
Copy link
Contributor Author

Closing in favor of later PR which will run as dev testing branch (makes same fixes)

@luketchang luketchang closed this Oct 19, 2021
@luketchang luketchang deleted the luke/watcher-config-map branch October 19, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emberian emberian Awaiting requested review from emberian

Assignees

@luketchang luketchang

Labels
agents Relating to rust agents refactor redesign or restructure rust 🦀 Rust dev work required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

watcher: Refactor ConnectionManager config
1 participant
@luketchang