e2e_test: Check receipts in smoke tests #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
piersy
force-pushed
the
piersy/smoketest
branch
from
8169cda to
3e50913
Compare
karlb
force-pushed
the
karlb/assert-receipts
branch
from
e68e983 to
3fd50f8
Compare
|
The smoke test in runs against alfajores in CI because there have been changes to the e2e tests. But it fails there due to https://github.com/celo-org/celo-blockchain-planning/issues/744 not being done. |
I needed to update chai due to chaijs/chai#1652
karlb
force-pushed
the
karlb/assert-receipts
branch
from
3fd50f8 to
d520c6e
Compare
|
Now that https://github.com/celo-org/celo-blockchain-planning/issues/744 is done, this PR passes CI including the run against alfajores. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to update chai due to chaijs/chai#1652
Closes https://github.com/celo-org/celo-blockchain-planning/issues/717