Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MintGoldSchedule #11040

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Rename MintGoldSchedule #11040

wants to merge 4 commits into from

Conversation

pahor167
Copy link
Contributor

@pahor167 pahor167 commented Jun 18, 2024 •
edited
Loading

Description

Raname MintGoldSchedule to MintCeloSchedule

@pahor167 pahor167 marked this pull request as ready for review June 18, 2024 07:24
@pahor167 pahor167 requested a review from a team as a code owner June 18, 2024 07:24
@pahor167 pahor167 changed the title Rename Mint Gold Schedule Rename MintGoldSchedule Jun 18, 2024
aaronmgdr
aaronmgdr reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@aaronmgdr aaronmgdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥰 🥳🙌🏻🎉

soloseng
soloseng requested changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@soloseng soloseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base branch should be the release/core-contracts/12 branch

There are a few other instances in the MintCeloSchedule where I couldnt leave a comment that still reference gold

packages/protocol/contracts/common/GoldToken.sol Outdated Show resolved Hide resolved
packages/protocol/contracts/common/GoldToken.sol Outdated Show resolved Hide resolved
packages/protocol/contracts/common/GoldToken.sol Outdated Show resolved Hide resolved
packages/protocol/contracts/common/GoldToken.sol Outdated Show resolved Hide resolved
packages/protocol/contracts/common/GoldToken.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/unit/common/MintCeloSchedule.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/unit/common/MintCeloSchedule.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/unit/common/MintCeloSchedule.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/unit/common/MintCeloSchedule.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/unit/common/MintCeloSchedule.t.sol Outdated Show resolved Hide resolved
@pahor167 pahor167 enabled auto-merge (squash) June 19, 2024 09:49
@aaronmgdr aaronmgdr mentioned this pull request Jun 20, 2024
Merged
@martinvol martinvol closed this Oct 11, 2024
auto-merge was automatically disabled October 11, 2024 15:40

Pull request was closed

@martinvol martinvol reopened this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronmgdr aaronmgdr aaronmgdr left review comments

@soloseng soloseng soloseng requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pahor167 @aaronmgdr @soloseng @martinvol