Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegation CLI commands #10642

Closed
wants to merge 5 commits into from
Closed

Delegation CLI commands #10642

wants to merge 5 commits into from

Conversation

pahor167
Copy link
Contributor

@pahor167 pahor167 commented Oct 4, 2023

Description

PR introduces new cli commands related to delegation
delegate
revoke-delegate
max-delegatees-count
update-delegated-amount

@pahor167 pahor167 requested a review from a team as a code owner October 4, 2023 09:58
@therealharpaljadeja
Copy link

Can we add the following commands too? @pahor167

  • total percent delegated by an account
  • list of delegatees for a delegator
  • total delegated votes to an address
image

@pahor167
Copy link
Contributor Author

pahor167 commented Oct 11, 2023 •
edited
Loading

Can we add the following commands too? @pahor167

  • total percent delegated by an account
  • list of delegatees for a delegator
  • total delegated votes to an address
image

I added new command delegate-info that shows required information

@pahor167 pahor167 requested a review from a team as a code owner October 11, 2023 11:40
therealharpaljadeja
therealharpaljadeja approved these changes Oct 19, 2023
View reviewed changes
Copy link

@therealharpaljadeja therealharpaljadeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

aaronmgdr
aaronmgdr requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@aaronmgdr aaronmgdr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For PRs that modify published packages such as CLI Please add a changeset by running yarn changeset add

@aaronmgdr
Copy link
Member

aaronmgdr commented Oct 20, 2023 •
edited
Loading

Isn't CR10 already out? Why is this not merging into master?

@pahor167
Copy link
Contributor Author

For PRs that modify published packages such as CLI Please add a changeset by running yarn changeset add

There doesn't seem to be any changeset in CR10 yet (we will have to wait for it to be merged to master probably)

@pahor167
Copy link
Contributor Author

Isn't CR10 already out? Why is this not merging into master?

Unfortunately CR10 was not merged into master yet @martinvol is working on that

@therealharpaljadeja therealharpaljadeja mentioned this pull request Oct 26, 2023
Closed
@therealharpaljadeja
Copy link

@pahor167 CR10 is merged!

@pahor167 pahor167 changed the base branch from martinvol/CR10Release to master November 6, 2023 12:55
@pahor167 pahor167 requested a review from a team as a code owner November 6, 2023 12:55
@pahor167 pahor167 requested review from a team November 6, 2023 12:55
@pahor167 pahor167 requested a review from a team as a code owner November 6, 2023 12:55
@pahor167 pahor167 requested review from a team and lvpeschke November 6, 2023 12:55
@pahor167 pahor167 changed the base branch from master to martinvol/CR10Release November 6, 2023 12:58
@pahor167
Copy link
Contributor Author

pahor167 commented Nov 6, 2023

I had some issues rebasing to master so I published new PR #10702

@pahor167 pahor167 closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronmgdr aaronmgdr aaronmgdr requested changes

@therealharpaljadeja therealharpaljadeja therealharpaljadeja approved these changes

@lvpeschke lvpeschke Awaiting requested review from lvpeschke lvpeschke was automatically assigned from celo-org/devopsre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pahor167 @therealharpaljadeja @aaronmgdr