[DO NOT MERGE] Gen1 Request Forwarding to Gen2 #10535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soloseng
changed the title
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
gastonponti
approved these changes
Aug 31, 2023
alecps
approved these changes
Sep 1, 2023
| proxyTimeout: config.phoneNumberPrivacy.odisServices.timeoutMilliSeconds, | ||
| }) | ||
|
|
||
| const originalPath = req.path |
There was a problem hiding this comment.
are you just trying to get the endpoint? You should be able to just use req.url for that
| case 'mainnet': | ||
| // XXX (soloseng):URL may need to be updated after gen2 function is created on mainnet | ||
| destinationUrl = | ||
| 'https://us-central1-celo-pgpnp-mainnet.cloudfunctions.net/combinerGen2' + |
There was a problem hiding this comment.
looks like you forgot to add strippedPath here
| } | ||
| proxy.on('error', (_) => { | ||
| logger.error('Error in Proxying request to Combiner.') | ||
| res.status(500).json({ |
There was a problem hiding this comment.
Will this override the actual error returned by the gen2 combiner? I'd rather just pass that along to the end user if possible
soloseng
changed the title
Closed
|
moved to celo-org/social-connect#46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turn
gen1cloud function into a proxy between client andgen2, when enabled by config.