misc cosmetic changes from review

celo-org · Aug 29, 2023 · 39369e2 · 39369e2
1 parent 3597a8a
commit 39369e2
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 36 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -31,7 +31,7 @@
   "[typescript]": {
     "editor.formatOnSave": true,
     "editor.codeActionsOnSave": {
-      "source.organizeImports": false
+      "source.organizeImports": true
     }
   },
   "[typescriptreact]": {

diff --git a/packages/phone-number-privacy/TODO.md b/packages/phone-number-privacy/TODO.md
@@ -1,25 +1,9 @@
 # TODO
 
-- (alec) fix domains tests
-- (Alec) check prometheus Counter
+- check prometheus Counter
 - Fix types in errorResult and sendFailure so we don't have to use ANY
 - Refactor domain sign handler to use db transactions properly
 - refactor authorization function with the new account model
 - resolve FAKE_URL for request url
-- Search for TODO comments for things to fix after load test
-- (nice to have) Refactor Combiner to be similar than signer (kill IO, Controller, Action)
 - Make caching config parameters configurable by environment
-- TODO comments
-
-## Done
-
-✔️ extract resultHandler() out of each handler, into the createHandler on server.ts
-✔️ correct Locals Type (logger should not be an ANY)
-✔️ (mariano) Implement chaching Account Service
-✔️ (mariano) Check Tracing Calls
-✔️ trace signature timeg
-✔️ (Mariano) remove catchErrorHandler2 (move it catchErrorHandler)
-✔️ Type Handler so Response has the correct Response Type
-✔️ Type Handlers so that Request is the proper type, or better use the "isValid Request" function
-✔️ fix primary key in requests table
-✔️ drop legacy tables
+- TODO comments 
diff --git a/packages/phone-number-privacy/combiner/src/common/crypto-clients/crypto-client.ts b/packages/phone-number-privacy/combiner/src/common/crypto-clients/crypto-client.ts
@@ -15,7 +15,6 @@ export abstract class CryptoClient {
   /**
    * Returns true if the number of valid signatures is enough to perform a combination
    */
-  // TODO (mcortesi) remove
   public hasSufficientSignatures(): boolean {
     return this.allSignaturesLength >= this.keyVersionInfo.threshold
   }

diff --git a/packages/phone-number-privacy/signer/package.json b/packages/phone-number-privacy/signer/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@celo/phone-number-privacy-signer",
-  "version": "3.0.0-beta.14",
+  "version": "3.0.0-beta.15",
   "description": "Signing participator of ODIS",
   "author": "Celo",
   "license": "Apache-2.0",

diff --git a/packages/phone-number-privacy/signer/scripts/local-load-test.ts b/packages/phone-number-privacy/signer/scripts/local-load-test.ts