This repository has been archived by the owner on Jan 22, 2019. It is now read-only.
CodeSynthesis XSD library (take 2) #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeSynthesis XSD is an XML bindings generator. This is the library to which generated bindings code will make calls. See http://www.codesynthesis.com/products/xsd/
|
#34 is for the actual discussion on the use of this approach in libCellML. This is not a subtask of #31. This code will not pass the tests as it stands, but that is probably ok for the purpose of this pull request. As Randall (@codecurve) points out above, this pull request is just to get the libxsd code into the repository as an external dependency without confusing things with the merging of actual libcellml developments. |
|
As above, the code doesn't need review and hasn't been reviewed, but I believe this pull request can be merged in. |
mirams
added a commit
that referenced
this pull request
Mar 3, 2015
Merge CodeSynthesis XSD library (take 2)
|
Doh! We all missed that, I think it was meant to be a pull/merge to develop, not master. |
|
OK, I have reverted the merge. Please resubmit the pull request against the develop branch. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the library code for CodeSynthesis XSD, no additional code.
This is currently off the head of the gtest01 branch, changes on that branch can be merged into this pull request.
This is a subtask of #31
It is not expected that the code itself will be reviewed. This code is unused at the moment, but has been isolated so that the next pull request towards this use case is not cluttered with so much additional code, which will hopefully make it easier to review that pull request.
This was originally #32, but @dnickerso requested this be done from the current master (since #28 has not been merged yet).