Skip to content
This repository has been archived by the owner on Jan 22, 2019. It is now read-only.

Roll back to just plain gtest. #26

Closed
wants to merge 1 commit into from
Closed

Roll back to just plain gtest. #26

wants to merge 1 commit into from

Conversation

codecurve
Copy link
Contributor

Google test setup for cellml/libcellml#25

@hsorby
Copy link
Contributor

hsorby commented Feb 17, 2015

My thoughts (in no particular order):

  • This pull request should be made against the develop branch of cellml/libcellml
  • src file names should be all lowercase
  • api header files put into libcellml directory so that all api includes are the same for internal calls
  • #include <Versioin.h> should be the first include in Version.cpp
  • header gaurds missing from LibcellmlConfig.h.in
  • patch version missing from version number
  • refactor CMakeLists.txt layout put CMakeLists.txt in src directory for the library target put CMakeLists.txt in tests  directory for the test targets, leaving the main CMakeLists.txt for handling general options, tests, build type etc.
  • not able to set type of library to build [shared, static]
  • library target should be named cellml, not add_library(Libcellml
  • version number variables should be all uppercase (Libcellml_VERSION_MAJOR)
  • test option should be LIBCELLML_TESTS with a test for TESTS variable, all configurable options should be namespaced with LIBCELLML_ for gui users
  • can’t set -g -Wall to CMAKE_CXX_FLAGS this is not generic to all compilers
  • check for cmake c++ compiler support is not well thought through, if there is a problem with the compiler it should be an error
  • version test doesn’t test anything

@nickerso
Copy link
Contributor

I agree with Hugh's comments. And would add that the actual commit message is not particularly useful or informative. It would be good to see more informative commit messages being used in future (I'm guessing this particular one is a consequence of where the code originated).

@codecurve
Copy link
Contributor Author

The target of a pull request can't be changed (isaacs/github/issues/18).
I'll close this and make the pull request again to the correct branch. My bad, sorry.

@codecurve codecurve closed this Feb 18, 2015
@codecurve codecurve mentioned this pull request Feb 18, 2015
@codecurve
Copy link
Contributor Author

The replacement pull request is cellml/libcellml#28

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants