fix tests

blob/blob.go

@@ -92,7 +92,7 @@ func (b *Blob) Data() []byte {
 
 func (b *Blob) ToProto() *BlobProto {
 	return &BlobProto{
-		NamespaceId:      b.namespace.Bytes(),
+		NamespaceId:      b.namespace.ID(),
 		NamespaceVersion: uint32(b.namespace.Version()),
 		ShareVersion:     uint32(b.shareVersion),
 		Data:             b.data,

blob/blob.proto

@@ -3,7 +3,7 @@ package pkg.blob;
 
 option go_package = "github.com/celestiaorg/go-square/blob";
 
-// BlobProto the protobuf representation of a blob (binary large object)
+// BlobProto is the protobuf representation of a blob (binary large object)
 // to be published to the Celestia blockchain. The data of a Blob is published
 // to a namespace and is encoded into shares based on the format specified by
 // share_version.

inclusion/commitment_test.go

@@ -86,7 +86,7 @@ func TestCreateCommitment(t *testing.T) {
 			namespace:    ns1,
 			blob:         bytes.Repeat([]byte{0xFF}, shares.AvailableBytesFromSparseShares(2)),
 			expectErr:    true,
-			shareVersion: uint8(1), // unsupported share version
+			shareVersion: uint8(2), // unsupported share version
 		},
 	}
 	for _, tt := range tests {

shares/split_sparse_shares.go

@@ -29,7 +29,6 @@ func (sss *SparseShareSplitter) Write(blob *blob.Blob) error {
 	rawData := blob.Data()
 	blobNamespace := blob.Namespace()
 
-	// First share (note by validating the blob we can safely cast the share version to uint8)
 	b, err := NewBuilder(blobNamespace, blob.ShareVersion(), true)
 	if err != nil {
 		return err