Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(syncer): set timeout for head request #152

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

vgonkivs
Copy link
Member

Overview

Set timeout to avoid the syncer being stuck on the Head request if the other node is unresponsive.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5a9f28) 63.85% compared to head (89c2b8f) 63.99%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   63.85%   63.99%   +0.13%     
==========================================
  Files          39       39              
  Lines        3389     3391       +2     
==========================================
+ Hits         2164     2170       +6     
+ Misses       1059     1054       -5     
- Partials      166      167       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sync/sync_head.go Outdated Show resolved Hide resolved
sync/sync_head.go Show resolved Hide resolved
sync/sync_head.go Show resolved Hide resolved
Co-authored-by: Hlib Kanunnikov <[email protected]>
Wondertan
Wondertan previously approved these changes Jan 30, 2024
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add timeout configuration as a good first issue

walldiss
walldiss previously approved these changes Jan 31, 2024
@Wondertan Wondertan dismissed stale reviews from walldiss and themself via 3126f41 January 31, 2024 13:48
walldiss
walldiss previously approved these changes Jan 31, 2024
@vgonkivs vgonkivs merged commit aa5a016 into celestiaorg:main Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kind:fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants