Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: flush the local tracer every 30s #1541

Closed
wants to merge 4 commits into from

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Nov 27, 2024

This changes help to flush the buffered writer in the file every 30s if not enough updates are happening.

This solves the issue of not seeing any traces when running a stable network

@rach-id rach-id self-assigned this Nov 27, 2024
@rach-id rach-id requested a review from a team as a code owner November 27, 2024 11:54
@rach-id rach-id requested review from rootulp, staheri14, evan-forbes and a team and removed request for a team November 27, 2024 11:54
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golangci-lint is complaining

rootulp
rootulp previously approved these changes Nov 27, 2024
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this PR modifies the function signature of some exported functions in the pkg/trace package so it may technically be considered breaking. NBD if we don't add ! to the PR title though b/c I assume you'll bump to this change in celestia-app and handle the function signature change

@rach-id
Copy link
Member Author

rach-id commented Nov 27, 2024

I didn't know it was used in app. Where is it please? @rootulp
If this is used downstream, we can make the change backwards compatible. I thought it's proper to core and it's fine to just change

@rootulp
Copy link
Collaborator

rootulp commented Nov 27, 2024

I didn't know it was used in app. Where is it please? @rootulp

Oops nvm it isn't used in app. Disregard

@rach-id
Copy link
Member Author

rach-id commented Nov 28, 2024

Closing this as I think it's unnecessary. The issue was happening because I was running a small network, only running 2 reactors, and the buffer doesn't receive enough data to write it.

However, in a realistic network, running all reactors, this shouldn't happen.

@rach-id rach-id closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants