Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump github.com/ethereum/go-ethereum from 1.14.7 to 1.14.8 #328

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 12, 2024

Bumps github.com/ethereum/go-ethereum from 1.14.7 to 1.14.8.

Release notes

Sourced from github.com/ethereum/go-ethereum's releases.

Rayingri (v1.14.8)

This is a maintenance release with bug fixes only.

Command changes

  • Blobpool related flags in Geth now actually work. (#30203)
  • The evm run command no longer overwrites the sender account in genesis.json. (#30259)
  • evm run now allows configuring baseFeePerGas in genesis.json. (#30281)

Go API

  • core/types.Transaction.ChainID had a bug where it modified the signature for very large ChainID (>= 2^64). (#30157)
  • ethclient.Client.NetworkID now supports values returned in hex format by the server. (#30263)
  • ethclient/simulated.Backend.AdjustTime was fixed to apply the correct time divison. (#30138)
  • accounts/abi/bind.TransactOpts now supports setting an access list for created transactions. (#30195)
  • The package p2p/simulations has been removed. (#30250)

Core

  • A snap-sync database corruption related to sync restarts is fixed in this release. (#30258)
  • eth_call storage overrides now work as originally intended: if a storage replacement object is specified in the call, previous storage values of the account are cleared. (#30185)
  • The txpool did not use the transaction's inline sender cache in some cases. (#30208)
  • The performance of EVM stack swaps was improved a bit. (#30249)

Networking

  • The downloader now takes withdrawals into account when sizing its queue. (#30276)
  • The new discovery node revalidation could hot-spin in certain rare scenarios. (#30239)
  • Configuring an external IP using --nat=extip:... could lead to invalid discovery packets being generated. (#30234)

Build

  • github.com/btcsuite/btcd/btcec has been upgraded to resolve a build error caused by upstream API changes. (#30181)
  • This release is built with Go 1.22.6. (#30273)

For a full rundown of the changes please consult the Geth 1.14.8 release milestone.


As with all our previous releases, you can find the:

Commits
  • a9523b6 Merge branch 'master' into release/1.14
  • 880511d params: release go-ethereum v1.14.8 stable
  • 5adf4ad eth/protocols/snap: cleanup dangling account trie nodes due to incomplete sto...
  • 33a13b6 p2p/simulations: remove packages (#30250)
  • 32a1e06 beacon/engine, consensus/beacon: use params.MaximumExtraDataSize instead of h...
  • 811a69c go.mod: update uint256 to 1.3.1 (#30280)
  • 83e70aa cmd/evm: fix evm basefee (#30281)
  • ebe31df eth/downloader, core/types: take withdrawals-size into account in downloader ...
  • d3dae66 tests: fix TransactionTest to actually run (#30272)
  • 9ea766d build: upgrade -dlgo version to Go 1.22.6 (#30273)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by CodeRabbit

  • New Features
    • Updated dependencies that may introduce new functionalities or improvements, enhancing overall module performance.
  • Bug Fixes
    • Potential fixes included in the updated versions of dependencies, improving stability and reliability.

Bumps [github.com/ethereum/go-ethereum](https://github.com/ethereum/go-ethereum) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/ethereum/go-ethereum/releases)
- [Commits](ethereum/go-ethereum@v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: github.com/ethereum/go-ethereum
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link

coderabbitai bot commented Aug 12, 2024

Walkthrough

The changes to the go.mod file for the github.com/celestiaorg/blobstream-contracts/v4 module involve updating three key dependencies. The updates include moving the Ethereum package to version v1.14.8, the btcec package to v2.3.4, and the uint256 package to v1.3.1. These version increments could enhance functionality and introduce minor fixes, potentially impacting the module's behavior and performance.

Changes

Files Change Summary
go.mod Updated github.com/ethereum/go-ethereum from v1.14.7 to v1.14.8; updated github.com/btcsuite/btcd/btcec/v2 from v2.2.0 to v2.3.4; updated github.com/holiman/uint256 from v1.3.0 to v1.3.1.

Poem

Hop, skip, and jump, oh what a delight,
Our dependencies leap to a new height! 🐇✨
With Ethereum shining, and btcec too,
We dance with uint256, all shiny and new.
Let’s celebrate changes, so fresh and so fine,
In the meadow of code, let our modules align! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 57c8c01 and 23afa1a.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • go.mod (2 hunks)
Additional comments not posted (3)
go.mod (3)

5-5: Update to github.com/ethereum/go-ethereum v1.14.8

The update from v1.14.7 to v1.14.8 is a maintenance release focusing on bug fixes. Ensure that any changes, especially those related to the Go API and command improvements, do not affect your current implementation. Review the release notes for any specific changes that might impact your project.


22-22: Update to github.com/holiman/uint256 v1.3.1

The update from v1.3.0 to v1.3.1 likely includes minor changes or improvements. Verify that these changes do not introduce any issues in your current use of the uint256 package.

Verification successful

Update to github.com/holiman/uint256 v1.3.1 Verified

The github.com/holiman/uint256 package is listed as an indirect dependency, and there is no direct usage found in the codebase. Therefore, the update to v1.3.1 should not introduce any issues in your current use of this package. The update is safe to proceed with as it primarily affects transitive dependencies.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the impact of the updated `github.com/holiman/uint256` dependency on the codebase.

# Test: Search for usage of `github.com/holiman/uint256` in the codebase.
# Expect: Review the usage to ensure compatibility with v1.3.1.
rg --type go 'github.com/holiman/uint256'

Length of output: 41


Script:

#!/bin/bash
# Description: Check for indirect usage of `github.com/holiman/uint256` in go.mod and go.sum.

# Search for `uint256` in go.mod to confirm it's listed as an indirect dependency.
rg 'github.com/holiman/uint256' go.mod

# Search for `uint256` in go.sum to see if it's listed as a transitive dependency.
rg 'github.com/holiman/uint256' go.sum

Length of output: 295


11-11: Update to github.com/btcsuite/btcd/btcec/v2 v2.3.4

The update from v2.2.0 to v2.3.4 suggests enhancements or fixes. Verify if there are any changes in cryptographic operations or APIs that could affect your application. Check the release notes for any relevant details.

Verification successful

No Direct Impact Found from github.com/btcsuite/btcd/btcec/v2 Update

The package github.com/btcsuite/btcd/btcec/v2 is not directly used in the codebase, as confirmed by the absence of direct imports. It is included as an indirect dependency. Ensure to review the release notes for any potential indirect impacts on dependencies that might rely on this package.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the impact of the updated `github.com/btcsuite/btcd/btcec/v2` dependency on the codebase.

# Test: Search for usage of `github.com/btcsuite/btcd/btcec/v2` in the codebase.
# Expect: Review the usage to ensure compatibility with v2.3.4.
rg --type go 'github.com/btcsuite/btcd/btcec/v2'

Length of output: 48


Script:

#!/bin/bash
# Description: Check for any indirect dependencies or usage of `github.com/btcsuite/btcd/btcec/v2` in the codebase.

# Search for any Go files that import packages from `github.com/btcsuite/btcd/btcec/v2`
rg --type go 'import "github.com/btcsuite/btcd/btcec/v2"' -A 5

# Check go.mod and go.sum for references to `github.com/btcsuite/btcd/btcec/v2`
rg 'github.com/btcsuite/btcd/btcec/v2' go.mod go.sum

Length of output: 377

@rach-id rach-id merged commit e88c524 into master Aug 13, 2024
12 checks passed
@rach-id rach-id deleted the dependabot/go_modules/github.com/ethereum/go-ethereum-1.14.8 branch August 13, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant