Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo fix #288

Merged
merged 1 commit into from
Feb 8, 2024
Merged

typo fix #288

merged 1 commit into from
Feb 8, 2024

Conversation

dferendo
Copy link
Contributor

@dferendo dferendo commented Feb 7, 2024

Overview

Typo Fix

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • Refactor
    • Updated variable names for consistency across multiple contracts, enhancing readability and maintainability.

Copy link

coderabbitai bot commented Feb 7, 2024

Walkthrough

The suite of changes across multiple files reflects a concerted effort to standardize variable naming by correcting initialVelsetNonce to initialValsetNonce. This adjustment enhances the clarity and consistency of the codebase, specifically within the context of contract initialization and setup procedures. The modifications span across both testing and benchmarking contracts, ensuring a uniform approach to variable nomenclature throughout the project.

Changes

File Path Change Summary
.../DAVerifier.t.sol, .../RollupInclusionProofs.t.sol Corrected initialVelsetNonce to initialValsetNonce in variable names and related function calls.
.../Blobstream.t.sol, .../BlobstreamBenchmark.t.sol Updated variable names from initialVelsetNonce to initialValsetNonce and adjusted corresponding function calls for consistency.

🐇✨
Changes abound, in code we trust,
From Velset to Valset, adjust we must.
Through lines of code, our errors bust,
In clean, clear naming, we place our trust.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ddd2b50 and f718898.
Files selected for processing (4)
  • src/lib/verifier/test/DAVerifier.t.sol (2 hunks)
  • src/lib/verifier/test/RollupInclusionProofs.t.sol (2 hunks)
  • src/test/Blobstream.t.sol (6 hunks)
  • src/test/BlobstreamBenchmark.t.sol (2 hunks)
Additional comments: 23
src/test/BlobstreamBenchmark.t.sol (5)
  • 48-48: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
  • 53-53: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
  • 55-55: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
  • 59-59: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
  • 86-86: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
src/test/Blobstream.t.sol (10)
  • 33-33: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
  • 37-37: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
  • 39-39: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
  • 43-43: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
  • 62-62: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
  • 70-70: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
  • 86-86: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
  • 93-93: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
  • 100-100: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
  • 115-115: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
src/lib/verifier/test/DAVerifier.t.sol (4)
  • 76-76: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
  • 80-80: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
  • 82-82: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
  • 97-97: Corrected typo in variable name from initialVelsetNonce to initialValsetNonce.
src/lib/verifier/test/RollupInclusionProofs.t.sol (4)
  • 210-210: Variable initialValsetNonce is correctly renamed, aligning with the PR's objective to fix the typo.
  • 214-214: The use of initialValsetNonce in domainSeparateValidatorSetHash call is correct and consistent with the variable renaming.
  • 216-216: The corrected variable name initialValsetNonce is used appropriately in the bridge.initialize call.
  • 233-233: The corrected variable name initialValsetNonce is used appropriately in the bridge.submitDataRootTupleRoot call.

@dferendo
Copy link
Contributor Author

dferendo commented Feb 8, 2024

@evan-forbes you need to add a label since i don't have permissions. thanks

@rach-id rach-id merged commit 048a12d into celestiaorg:master Feb 8, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants