-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo fix #288
typo fix #288
Conversation
WalkthroughThe suite of changes across multiple files reflects a concerted effort to standardize variable naming by correcting Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (4)
- src/lib/verifier/test/DAVerifier.t.sol (2 hunks)
- src/lib/verifier/test/RollupInclusionProofs.t.sol (2 hunks)
- src/test/Blobstream.t.sol (6 hunks)
- src/test/BlobstreamBenchmark.t.sol (2 hunks)
Additional comments: 23
src/test/BlobstreamBenchmark.t.sol (5)
- 48-48: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.- 53-53: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.- 55-55: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.- 59-59: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.- 86-86: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.src/test/Blobstream.t.sol (10)
- 33-33: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.- 37-37: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.- 39-39: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.- 43-43: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.- 62-62: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.- 70-70: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.- 86-86: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.- 93-93: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.- 100-100: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.- 115-115: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.src/lib/verifier/test/DAVerifier.t.sol (4)
- 76-76: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.- 80-80: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.- 82-82: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.- 97-97: Corrected typo in variable name from
initialVelsetNonce
toinitialValsetNonce
.src/lib/verifier/test/RollupInclusionProofs.t.sol (4)
- 210-210: Variable
initialValsetNonce
is correctly renamed, aligning with the PR's objective to fix the typo.- 214-214: The use of
initialValsetNonce
indomainSeparateValidatorSetHash
call is correct and consistent with the variable renaming.- 216-216: The corrected variable name
initialValsetNonce
is used appropriately in thebridge.initialize
call.- 233-233: The corrected variable name
initialValsetNonce
is used appropriately in thebridge.submitDataRootTupleRoot
call.
@evan-forbes you need to add a label since i don't have permissions. thanks |
Overview
Typo Fix
Checklist
Summary by CodeRabbit