Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: use a struct for namespace and rename namespaceID #175

Merged
merged 10 commits into from
Sep 8, 2023
Merged

feat!: use a struct for namespace and rename namespaceID #175

merged 10 commits into from
Sep 8, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Aug 12, 2023

Overview

Closes #172 and #174

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id self-assigned this Aug 12, 2023
@rach-id rach-id marked this pull request as draft August 12, 2023 14:10
@rach-id rach-id marked this pull request as ready for review August 12, 2023 15:50
@rach-id rach-id requested a review from adlerjohn August 12, 2023 15:50
rootulp
rootulp reviewed Aug 12, 2023
View reviewed changes
src/lib/tree/Types.sol Outdated Show resolved Hide resolved
@adlerjohn adlerjohn linked an issue Aug 22, 2023 that may be closed by this pull request
Use a struct for namespace #174
Closed
evan-forbes
evan-forbes previously approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adlerjohn
adlerjohn reviewed Aug 23, 2023
View reviewed changes
src/lib/tree/Types.sol Show resolved Hide resolved
src/lib/tree/Constants.sol Show resolved Hide resolved
src/lib/tree/Constants.sol Outdated Show resolved Hide resolved
@rach-id rach-id requested a review from adlerjohn August 23, 2023 13:58
adlerjohn
adlerjohn reviewed Aug 27, 2023
View reviewed changes
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment above

@rach-id rach-id enabled auto-merge (squash) September 7, 2023 11:18
adlerjohn
adlerjohn previously approved these changes Sep 8, 2023
View reviewed changes
evan-forbes
evan-forbes previously approved these changes Sep 8, 2023
View reviewed changes
@rach-id
Merge branch 'master' into struct-namespace
073ba29 
# Conflicts:
#	wrappers/QuantumGravityBridge.sol/wrapper.go
@rach-id rach-id dismissed stale reviews from evan-forbes and adlerjohn via 073ba29 September 8, 2023 10:22
@rach-id rach-id merged commit eb7a4e7 into celestiaorg:master Sep 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp left review comments

@adlerjohn adlerjohn adlerjohn approved these changes

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

Assignees

@rach-id rach-id

Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a struct for namespace rename namespace ID to namespace
4 participants
@rach-id @adlerjohn @rootulp @evan-forbes