Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): Make SerializationException implement BadRequestException #32

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

dnys1
Copy link
Member

@dnys1 dnys1 commented Feb 8, 2024

When thrown on the server, a serialization exception means that the server received bad data from the client.

Copy link
Member Author

dnys1 commented Feb 8, 2024

@dnys1 dnys1 force-pushed the chore/core/serialization-bad-request branch from 8cf5bc8 to b7c80ad Compare February 8, 2024 00:12
Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member Author

dnys1 commented Feb 8, 2024

Merge activity

  • Feb 7, 7:35 PM EST: @dnys1 started a stack merge that includes this pull request via Graphite.
  • Feb 7, 7:38 PM EST: Graphite rebased this pull request as part of a merge.
  • Feb 7, 7:39 PM EST: @dnys1 merged this pull request with Graphite.

@dnys1 dnys1 force-pushed the chore/version/0.2.0-dev branch from b927990 to 74faa88 Compare February 8, 2024 00:36
Base automatically changed from chore/version/0.2.0-dev to main February 8, 2024 00:37
…tion`

When thrown on the server, a serialization exception means that the server received bad data from the client.
@dnys1 dnys1 force-pushed the chore/core/serialization-bad-request branch from b7c80ad to a4a2da4 Compare February 8, 2024 00:37
@dnys1 dnys1 merged commit 607cdbf into main Feb 8, 2024
2 checks passed
@dnys1 dnys1 deleted the chore/core/serialization-bad-request branch February 8, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants