Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): Improve SerializationException message #10

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

dnys1
Copy link
Member

@dnys1 dnys1 commented Jan 23, 2024

While this exception can be thrown on the client or server, it is only thrown on the client by fault of the user. And there is only one reason why this would be the case.

Copy link
Member Author

dnys1 commented Jan 23, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

While this exception can be thrown on the client or server, it is only thrown on the client by fault of the user. And there is only one reason why this would be the case.
@dnys1 dnys1 force-pushed the chore/better-serialization-exception branch from 8b15a8c to 27adcb9 Compare January 23, 2024 02:42
Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnys1 dnys1 merged commit 8082781 into main Jan 23, 2024
2 checks passed
@dnys1 dnys1 deleted the chore/better-serialization-exception branch January 23, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants