chore(deps): update dependency pyjwt to v2.10.1 [security] #697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
==2.10.0
->==2.10.1
Review
GitHub Vulnerability Alerts
CVE-2024-53861
Summary
The wrong string if check is run for
iss
checking, resulting in"acb"
being accepted for"_abc_"
.Details
This is a bug introduced in version 2.10.0: checking the "iss" claim
changed from
isinstance(issuer, list)
toisinstance(issuer, Sequence)
.Since str is a Sequnce, but not a list,
in
is also used for stringcomparison. This results in
if "abc" not in "__abcd__":
beingchecked instead of
if "abc" != "__abc__":
.PoC
Check out the unit tests added here: https://github.com/jpadilla/pyjwt-ghsa-75c5-xw7c-p5pm
Impact
I would say the real world impact is not that high, seeing as the signature still has to match. We should still fix it.
Release Notes
jpadilla/pyjwt (PyJWT)
v2.10.1
Compare Source
Configuration
📅 Schedule: Branch creation - "" in timezone America/Montreal, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.