Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/groups sync #684

Merged
merged 7 commits into from
Oct 18, 2024
Merged

Fix/groups sync #684

merged 7 commits into from
Oct 18, 2024

Conversation

gcharest
Copy link
Contributor

Summary | Résumé

Feature:

  • Introduce a retry_request function to retry failed calls. The default retry is set to 3. This should help deal with the timed out errors we have seen.

Fix:

  • Google Directory integration would return members without their details even if an error occurred during the get_user api call. I introduced a new, distinct function to get the members details. If a single error occurs, an empty array is return unless the tolerate error flag is set.
  • The above also should fix the issue where a group sync would fail due to some of their users missing the primaryEmail key on their details since this is only possible when the get_user call succeeds.

@gcharest gcharest requested a review from a team October 18, 2024 15:46
@gcharest gcharest self-assigned this Oct 18, 2024
@gcharest gcharest enabled auto-merge (squash) October 18, 2024 15:47
Copy link

github-actions bot commented Oct 18, 2024

GitHub Action status on 54ee1bb generated by comment-failure-action

Lint, format and test code

job url
null https://github.com/cds-snc/sre-bot/actions/runs/11406832811/job/31741470774

Build containers CI

No jobs failed 👍

@gcharest gcharest merged commit 0fd44cf into main Oct 18, 2024
7 checks passed
@gcharest gcharest deleted the fix/groups_sync branch October 18, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants