Fix/list groups w users #667

gcharest · 2024-10-02T19:45:36Z

Summary | Résumé

Standardize and simplify listing groups members from integrations (AWS and Google)
Add a function to flatten results into a data frame for more performant processing of large data sets

github-actions · 2024-10-02T19:46:54Z

GitHub Action status on 14807cb generated by comment-failure-action

job	url
null	https://github.com/cds-snc/sre-bot/actions/runs/11150553964/job/30991950088

No jobs failed 👍

sylviamclaughlin · 2024-10-02T20:57:12Z

app/integrations/aws/identity_store.py

+            }
+            flattened_data.append(flattened_record)
+
+    return pd.DataFrame(flattened_data)


Nice that you are converting this to a data frame.

gcharest added 9 commits October 1, 2024 17:45

feat: ensure only required keys are kept

e2b7ecb

fix: adjust the fixture for expected google groups with members

0a599c0

feat: add function to export groups to data frame

7d88223

fix: return properly formatted groups data in dataframe

82391e4

fix: update list groups w members to handle errors

98cccf7

fix: simplify method's logic

1f5ef1e

fix: simplify method and handle errors

50a7bcd

fix: simplify method

501321c

fix: cleanup logs

14807cb

gcharest requested a review from a team October 2, 2024 19:45

gcharest self-assigned this Oct 2, 2024

fix: fmt

2b67b48

gcharest enabled auto-merge (squash) October 2, 2024 19:50

gcharest disabled auto-merge October 2, 2024 19:52

sylviamclaughlin reviewed Oct 2, 2024

View reviewed changes

sylviamclaughlin approved these changes Oct 2, 2024

View reviewed changes

gcharest merged commit 9684ed3 into main Oct 2, 2024
7 checks passed

gcharest deleted the fix/list_groups_w_users branch October 2, 2024 23:24