Fix/get user timeout #665
Merged
Fix/get user timeout #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylviamclaughlin
approved these changes
Oct 1, 2024
wanpengyang
reviewed
Oct 1, 2024
| error_occurred = True | ||
| if not tolerate_errors: | ||
| break | ||
| if error_occurred and not tolerate_errors: |
There was a problem hiding this comment.
shouldn't this be continue when tolerate_errors instead of not tolerate_errors?
There was a problem hiding this comment.
Yes, I think you're correct... I'll double check my unit test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Update the Google list groups with users to handle cases where an API time out error breaks the sync job.
Add a tolerate error flag to continue processing users (set to default False)