Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/handle webhook #651

Merged
merged 19 commits into from
Sep 17, 2024
Merged

Refactor/handle webhook #651

merged 19 commits into from
Sep 17, 2024

Conversation

gcharest
Copy link
Contributor

Summary | Résumé

3rd time's the charm! I hope...

Fixed:

  • Pass AWS SNS Payload object to the aws.parse method instead of the payload.Message only.
  • Pass the properly formatted Webhook payload to the append incident buttons method.
  • Update the append incident buttons to handle cases where the WebhookPayload.attachments is None or a str

@gcharest
feat: move models to models/webhooks
b3d77ab
@gcharest
feat: add models utils methods
be69f44
@gcharest
chore: improve docstrings
ac41c37
@gcharest
fix: add string payload validation
662cb38
@gcharest
feat: handle aws sns payload
52b01f3
@gcharest
fix: remove trailing comma
ce3f00c
@gcharest
feat: add test for invalid type
dc35601
@gcharest
fix: test invalid signature version
a0b8a22
@gcharest
fix: test all exceptions on handle sns payload
14f3e7e
@gcharest
fix: rename to validate sns payload
954ef63
@gcharest
fix: lint
ac59256
@gcharest
refactor: break handle webhook with separate string handler
e097207
@gcharest
fix: handle upptime payload
df00773
@gcharest
fix: add missing module
d138b53
@gcharest
fix: rate limiting test on webhooks endpoint
050fcdb
@gcharest
fix: dump model before calling bot api
273b374
@gcharest
fix: ensure AWS SNS payload properly parsed
a468440
@gcharest
fix: pass proper payloads to methods
4937cdc
@gcharest
fix: handle cases where attachements may be None
9d1fd3d
@gcharest gcharest requested a review from a team September 17, 2024 13:17
@gcharest gcharest self-assigned this Sep 17, 2024
@gcharest gcharest merged commit 6705e55 into main Sep 17, 2024
8 checks passed
@gcharest gcharest deleted the refactor/handle_webhook branch September 17, 2024 13:36
gcharest added a commit that referenced this pull request Sep 17, 2024
@gcharest
Revert "Refactor/handle webhook (#651)"
6ff14a3 
This reverts commit 6705e55.
@gcharest gcharest mentioned this pull request Sep 17, 2024
Merged
gcharest added a commit that referenced this pull request Sep 17, 2024
@gcharest
Revert "Refactor/handle webhook (#651)" (#652)
0b9a57b 
This reverts commit 6705e55.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patheard patheard patheard approved these changes

Assignees

@gcharest gcharest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcharest @patheard