Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Upptime SlackRequest model structure #643

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Conversation

gcharest
Copy link
Contributor

Summary | Résumé

Attempt to fix the errors triggered when the Upptime status raises an error on downtime and pushes a notification to Slack.

Using the type definition found here as a reference.

@gcharest gcharest requested a review from a team September 12, 2024 17:59
@gcharest gcharest self-assigned this Sep 12, 2024
Copy link

github-actions bot commented Sep 12, 2024

GitHub Action status on 45a7c41 generated by comment-failure-action

Lint, format and test code

job url
null https://github.com/cds-snc/sre-bot/actions/runs/10836174351/job/30069338468

Build containers CI

No jobs failed 👍

Copy link

github-actions bot commented Sep 12, 2024

GitHub Action status on 14fc21f generated by comment-failure-action

Lint, format and test code

job url
null https://github.com/cds-snc/sre-bot/actions/runs/10836330137/job/30069849555

Build containers CI

No jobs failed 👍

Copy link
Member

@patheard patheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this ❤️

@gcharest gcharest merged commit 37f68b0 into main Sep 13, 2024
7 checks passed
@gcharest gcharest deleted the fix/upptime_payload branch September 13, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants