Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/refactor incident helper with integrations #616

Merged
merged 7 commits into from
Aug 7, 2024

Conversation

gcharest
Copy link
Contributor

@gcharest gcharest commented Aug 7, 2024

Summary | Résumé

  • Refactor the incident helper (used with /sre incident command) to use generic Google integrations modules instead of the catchall google_drive module (became a very large file with lots of process specific configuration)
  • Introduce the Google Sheets module
  • Add typing annotations when possible

Additional fixes:

  • Refactoring required some updates to the execute api function, namely supporting the fields argument as a supported parameter in the api calls.
  • Google Drive and Docs also were updated to support fields as an arg
  • Delegated user email has been added to functions with write permissions so that they can possibly be executed by using the caller's identity instead of the bot's, thus inheriting their permissions in Google Workspace

@gcharest gcharest requested a review from a team August 7, 2024 17:47
@gcharest gcharest self-assigned this Aug 7, 2024
@gcharest gcharest merged commit d11a28f into main Aug 7, 2024
8 checks passed
@gcharest gcharest deleted the feat/refactor_former_google_drive_module branch August 7, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants